gfscott / eleventy-plugin-embed-everything

An Eleventy plugin to easily embed common media formats in posts, using only their URLs
https://gfscott.com/embed-everything/
MIT License
99 stars 6 forks source link

Refactor spotify #186

Closed gfscott closed 1 year ago

gfscott commented 1 year ago

This PR is a substantial refactor of how the Spotify plugin works under the hood, based on the new architecture I came up with for the TED plugin. The public API is unchanged, and end users should not notice any difference to how it works in their Eleventy apps.

Changes in brief:

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 23ae98b8262a12a24dcfc8ffb57636ced4084273

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (3d09039) 100.00% compared to head (23ae98b) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #186 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 6 -3 Lines 106 96 -10 ========================================= - Hits 106 96 -10 ``` [see 3 files with indirect coverage changes](https://app.codecov.io/gh/gfscott/eleventy-plugin-embed-everything/pull/186/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Graham+F.+Scott)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.