Refactor Vimeo plugin - Githubissues

gfscott / eleventy-plugin-embed-everything

An Eleventy plugin to easily embed common media formats in posts, using only their URLs

https://gfscott.com/embed-everything/

MIT License

99 stars 6 forks source link

Refactor Vimeo plugin #196

Closed gfscott closed 1 year ago

gfscott commented 1 year ago

This PR is a substantial under-the-hood refactor of the Vimeo plugin. The public API is unchanged, and end users shouldn't notice any difference in how it works in their Eleventy apps.

Changes in brief:

Reduces the number of regular expressions from 2 to 1.
- Older versions had a regex to find each relevant URL, and another to replace each instance. The new architecture has just one, with a single replace function that runs once per processed file.
Adds a lot more tests and tests more thoroughly. The total number of tests run on the plugin has increased from 104 to 1,568.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 16d9f86e3dd60e2f8b7f48555e52428e7bfe443d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | -------------------------------- | ----- | | eleventy-plugin-vimeo-embed | Patch | | eleventy-plugin-embed-everything | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR