Closed gfscott closed 10 months ago
Latest commit: 24729e1d45d4f83d2f0aea02d8d75b3792b15317
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c95fb38
) 100.00% compared to head (24729e1
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Twitter changed its oEmbed API by adding an extra newline at the end of the returned HTML string. This updates the tests so they account for the change.
Annoying but I guess this is why I made these tests in the first place, so we'd know if the API contract changed. I'm not making a changeset or bumping the version here because it's really a change on Twitter's end, not ours. And I think if you're using oEmbed, then you've opted in to accepting the HTML content returned from that third-party service.