Closed gfscott closed 9 months ago
Latest commit: ac4c936fe523b01927d4ce293be1cdb40e516f27
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cbab6b4
) 100.00% compared to head (ac4c936
) 100.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Close #205
This PR adds several options related to YouTube embed titles:
title
attribute is now configurable as an option. The default value remains the same.How to use it
This simplified example shows the new title options in action:
Notes on implementation
.replace
prototype is synchronous, which makesawait
ing the title impossible, so we now use the string-replace-async package instead.titleOptions.download
or not. I worry a smidge about backward compatibility as a result, but hey, that's what semantic versioning is for, I guess..replace()
. It seems to be at parity.