gfscott / eleventy-plugin-embed-everything

An Eleventy plugin to easily embed common media formats in posts, using only their URLs
https://gfscott.com/embed-everything/
MIT License
99 stars 6 forks source link

Revert "Merge pull request #224 from gfscott/youtube-title" #231

Closed gfscott closed 9 months ago

gfscott commented 9 months ago

This PR reverts an issue introduced in youtube@1.10.0/everything@1.18.0, where you'd get duplicate video embeds — the last YouTube ID processed would override all YouTube embeds on the same page. Obviously that is not the intended functionality. Hat tip to @patrulea for filing #230 to raise the issue.

I've isolated the source of the problem, which originates in #224, and reverted those changes for now. I'll release this as a patch and hopefully I can bring back the dynamic YouTube title feature in a future release. Apologies if this caused any disruptions for folks in the couple days this release was in the wild.

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 5fb9ec007c74505d48f57f7ef732b71c658dec5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | -------------------------------- | ----- | | eleventy-plugin-youtube-embed | Patch | | eleventy-plugin-embed-everything | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR