gftea / amqprs

Async & Lock-free RabbitMQ Rust Client, Easy-to-use API
MIT License
214 stars 27 forks source link

support message size larger than frame-max (#46) #47

Closed gftea closed 1 year ago

gftea commented 1 year ago

Close #46

codecov[bot] commented 1 year ago

Codecov Report

Merging #47 (ec3b646) into main (825aaeb) will increase coverage by 0.16%. The diff coverage is 96.90%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   85.16%   85.32%   +0.16%     
==========================================
  Files          42       42              
  Lines        5756     5833      +77     
==========================================
+ Hits         4902     4977      +75     
- Misses        854      856       +2     
Impacted Files Coverage Δ
amqprs/src/api/channel/mod.rs 94.11% <ø> (ø)
amqprs/src/net/writer_handler.rs 82.85% <ø> (+1.60%) :arrow_up:
amqprs/src/api/connection.rs 87.52% <80.00%> (+0.25%) :arrow_up:
amqprs/src/net/split_connection.rs 93.71% <96.36%> (+0.67%) :arrow_up:
amqprs/src/api/callbacks.rs 50.00% <100.00%> (+3.62%) :arrow_up:
amqprs/src/api/channel/dispatcher.rs 89.44% <100.00%> (+0.61%) :arrow_up:
amqprs/src/api/consumer.rs 97.87% <100.00%> (+0.57%) :arrow_up:
amqprs/src/frame/mod.rs 83.69% <0.00%> (-1.09%) :arrow_down:
amqprs/src/api/channel/basic.rs 91.31% <0.00%> (-0.35%) :arrow_down:
... and 2 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

michaelklishin commented 1 year ago

It would be nice to add a test case that publishes empty messages (which are framed as [basic.publish frame] and [content header frame] and zero message body frames :)

gftea commented 1 year ago

it is included already, thanks for comment