search

gftea / amqprs

Async & Lock-free RabbitMQ Rust Client, Easy-to-use API
MIT License
214 stars 27 forks source link

BasicPublishArguments: deprecate immediate field #86

Closed michaelklishin closed 1 year ago

michaelklishin commented 1 year ago

RabbitMQ versions starting with 3.0.0 do not support it.

Closes #82

codecov[bot] commented 1 year ago

Codecov Report

Merging #86 (1e45c08) into main (fdc93dd) will decrease coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   85.84%   85.83%   -0.02%     
==========================================
  Files          42       42              
  Lines        6120     6120              
==========================================
- Hits         5254     5253       -1     
- Misses        866      867       +1
Impacted Files Coverage Δ
amqprs/src/api/channel/basic.rs 91.66% <ø> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gftea commented 1 year ago

the build failed due to clippy error, please check

michaelklishin commented 1 year ago

Clippy warns of deprecated field usage in the library itself. Disabling it for individual expressions is considered experimental.

I guess I'll just leave it as is since any user of this field will get a visible connection error from RabbitMQ.