gftea / amqprs

Async & Lock-free RabbitMQ Rust Client, Easy-to-use API
MIT License
214 stars 27 forks source link

Address (most) clippy warnings #87

Closed michaelklishin closed 1 year ago

michaelklishin commented 1 year ago

A lot of cargo clippy warnings are unused variables and trivial things like that. Should I submit a PR that squashes as many of them as possible within a certain time box (say, a couple of hours)?

michaelklishin commented 1 year ago

Now I understand why: most warnings come from conditionally compiled code like this:

Err(err) => {
  #[cfg(feature="traces")]
  error!("cancel callback error on channel {}, cause: '{}'.", self.channel, err);
}
gftea commented 1 year ago

If compiles with all features, it should be no warning

michaelklishin commented 1 year ago

If compiles with all features, it should be no warning

Fair enough.