search

gfwilliams / svgtoeagle

Online SVG to Eagle CAD converter
MIT License
85 stars 26 forks source link

Update default scale #27

Closed ToastyStoemp closed 1 year ago

ToastyStoemp commented 1 year ago

Update default scale to match the new WC3 standard of 96 pixels per mm ( https://www.w3.org/TR/SVG/coords.html#Units )

gfwilliams commented 1 year ago

While I'm for all making it compliant with the spec, were you finding that the size of files when imported was wrong before?

I'm just conscious that the current number was chosen based on trying Inkscape SVGs, and if this changes and it was right before then a bunch of users are going to end up unhappy

ToastyStoemp commented 1 year ago

yes, I only recently noticed that my files weren't actually the right size, hence I went googling on what the scale should be rather than guessing (also using inkscape)

ToastyStoemp commented 1 year ago

I had mainly been using the tool for logo's and roughly the same size was good enough, logo's just had to be the same size. But for a current project I need something that's the exact size of the PCB. 301.75mm, when using the default settings it exported to 323 ish mm.

ToastyStoemp commented 1 year ago

Ah I found the reason: Inkscape patch 0.92 changed the default DPI from 90 to 96 to match the CSS standard: https://inkscape.org/release/inkscape-0.92/ first note under Important Changes

gfwilliams commented 1 year ago

Ahh, that's great - thanks for figuring that out!

And 0.92 was released 5 years ago now so really there's very little chance the old 90dpi setting makes sense any more.

Merging now - thanks for all your help with this!