search

gfx-rs / gfx-ocean

Compute based ocean simulation with gfx_hal :ocean:
116 stars 7 forks source link

Add additional Camera controls #7

Closed dav-s closed 6 years ago

dav-s commented 6 years ago

Hi!

Awesome project!

I am taking a Graphics class this semester that has gotten me really interested in the field. So far in our class, we have implemented a ray tracer and made a project using OpenGL (we actually had to make an ocean for part of it but it was much more simple than this one haha).

Anyways, I have always been interested in Rust but have never actually worked on any projects using it. I found this project via the gfx-rs website and was very impressed. When I ran the program (took a while to start on my MacBook Air), I noticed that there was no mouse or strafing control. This was great because it was something I knew the basic idea of how to implement!

Changes made:

I would really appreciate any feedback! This is my first time pushing Rust code, so I am super eager to learn how to improve!

Thanks!

dav-s commented 6 years ago

I also realized in my original PR, I was clamping the pitch from [-1, 1] instead of something closer to [-pi/2, pi/2]. I have now changed it to be closer to that. Now, you can look up and down at steeper angles.