Closed kvark closed 3 years ago
New timing - cargo-timing-20201202T054953Z.html.zip Old timing - cargo-timing-20201202T055308Z.html.zip
It's clear that gfx
itself doesn't take more time to build. In fact, even less.
But in total the time now has to include the thiserror
dependencies, including syn
, quote
, and proc-macro
.
So it's a question of whether we expect the clients to already depend on thiserror
(in which case it's free), or not.
The benefit is clear - our code becomes more manageable (+338 −865).
I believe the most important (current and future) consumers of gfx-hal are:
wgpu
- already uses thiserror
amethyst
- uses thiserror
transitively through cpal
, also depends on a lot of other crates that drag syn
and friends inwebrender
- also not a concern for itSo I think we should bite the bullet and go for it.
bors r+
Build succeeded:
Makes error variants a bit more sane and structured. Also takes advantage of
thiserror
, since that's what we settled on inwgpu
land. PR checklist:make
succeeds (on *nix)make reftests
succeedsNew code (HAL only):
Old code (HAL only):