Closed psumbera closed 1 year ago
We no longer have the "xcb" feature, so we can't follow your suggested fix.
However, what we should do is just mirroring RawWindowHandle
feature flags when checking for Xlib. See https://github.com/rust-windowing/raw-window-handle/blob/73a41ea28907b0f261816136b1b3f39cfdd791f3/src/lib.rs#L121-L125
Started the discussion about BSD configs on the rust-internals forum...
Ok. Shall I wait with submitting following fix?
index c5f27e73..22afacbe 100644
--- a/src/backend/vulkan/src/lib.rs
+++ b/src/backend/vulkan/src/lib.rs
@@ -589,7 +589,8 @@ impl hal::Instance<Backend> for Instance {
unix,
not(target_os = "android"),
not(target_os = "macos"),
- not(target_os = "ios")
+ not(target_os = "ios"),
+ not(target_os = "solaris"),
))]
RawWindowHandle::Xcb(handle)
if self
if you can instead make a PR with the configuration used by RawWindowHandle code, that would be great!
if you can instead make a PR with the configuration used by RawWindowHandle code, that would be great!
Sorry I think I'm still missing what change I should prepare. Can you please more elaborate what and where I should put.
I believe the match arms for RWH in gfx-rs have to be gated the same way as they are in RWH definition itself, see the link I provided earlier. For Xcb in particular, this would be:
cfg(any(
target_os = "linux",
target_os = "dragonfly",
target_os = "freebsd",
target_os = "netbsd",
target_os = "openbsd"
))
There is actually one year old pull request for that. Can you please have look at it?
Thank you! Let's see how they respond now that you pinged them.
@psumbera: Is this still an issue we should resolve here?
No, we can close the issue now.
Seems to be caused by:
https://github.com/gfx-rs/gfx/commit/a498b475003c03319d9d79ce2eae0c1d3f1e9813
Following seems to fix the issue: