Closed kvark closed 3 years ago
I think this is ready for review/landing! Interestingly, the refactor on GL ended up without as much boilerplate as I feared. I figured there is no need to maintain any caches of framebuffers, since we can mutate existing ones. That nails down pretty much the only concern I had with the change, and I'm very happy to see what it came to be, after so much experimentation and wasted code!
@manugildev thank you for taking a look! bors r=manugildev
Build failed:
bors r=manugildev
Fixes #3568 It will also solve the annoying validation error about Vulkan framebuffers being destroyed - #3015. Even though we still rely on the "acquire" to actually make the image available, the framebuffers in Vulkan are going to be more solid and persistent. No creation/removal each frame any more! 🎉 🚀