gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.
http://gfx-rs.github.io/
Apache License 2.0
5.35k stars 548 forks source link

[GL] Android emulator support #3592

Closed Gordon-F closed 3 years ago

Gordon-F commented 3 years ago

PR checklist:

Android emulator doesn't support EGL_KHR_surfaceless_context.

Gordon-F commented 3 years ago

@kvark I think I fixed all suggestions. Thank you for reviewing!

kvark commented 3 years ago

Sweet! Bors r+

On Jan 16, 2021, at 15:32, Igor Shaposhnik notifications@github.com wrote:

 @Gordon-F commented on this pull request.

In src/backend/gl/src/window/egl.rs:

@@ -285,10 +298,23 @@ impl hal::Instance for Instance {

 fn enumerate_adapters(&self) -> Vec<hal::adapter::Adapter<crate::Backend>> {
     let inner = self.inner.lock();
  • inner
  • .egl
  • .make_current(inner.display, None, None, Some(inner.context))
  • .unwrap();
  • if let Some(pbuffer) = inner.pbuffer {
  • inner Removed if and checked on the emulator and device. Everything is working fine.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

bors[bot] commented 3 years ago

Build succeeded: