search

gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.
http://gfx-rs.github.io/
Apache License 2.0
5.35k stars 548 forks source link

[vk] don't forget to enable maintenance-1 #3595

Closed kvark closed 3 years ago

kvark commented 3 years ago

Apparently, enabling maintenance-2 doesn't auto-enable maintenance-1. Who'd new? That manifests in our NDC inversion going broke:

[1.285790 ERROR]()(no module): VALIDATION [VUID-VkViewport-height-01772 (-1596201395)] : Validation Error: [ VUID-VkViewport-height-01772 ] Object 0: handle = 0x559394238118, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xa0dbe64d | vkCmdSetViewport: pViewports[0].height (=-600.000000) is not greater 0.0. The Vulkan spec states: height must be greater than 0.0 (https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#VUID-VkViewport-height-01772) object info: (type: COMMAND_BUFFER, hndl: 94092333908248)

kvark commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Canceled.

kvark commented 3 years ago

one tiny fix is added about GLSL versions bors r+

bors[bot] commented 3 years ago

Build succeeded: