Use non-ARB functions in bind_blend_slot

gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.

http://gfx-rs.github.io/

Apache License 2.0

5.35k stars 548 forks source link

Use non-ARB functions in bind_blend_slot #3617

Closed alula closed 3 years ago

alula commented 3 years ago

Fixes #2685

PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends:
gl

alula commented 3 years ago

...is pre-ll branch even maintained somewhere?

kvark commented 3 years ago

@alula it's not really maintained any more. We have enough on our plates beside that. If you are interested, we can arrange you the power to do that.

kvark commented 3 years ago

I think what makes a difference here is the GLES vs GL. On GL, the ARB extensions are more compatible, since they will be there all the time, and the core versions may not. But on GLES, the core is relatively capable, and at times no extensions even are developed for something in core. So for GLES, we'd use the non-ARB, and for GL we'd use ARB.

Anyhow, the CI is sad (not because of this PR, but still), and we have this situation with "pre-ll" unmaintained, so unable to merge it.

alula commented 3 years ago

why don't move the pre-ll branch to another repo tho?

kvark commented 3 years ago

why don't move the pre-ll branch to another repo tho?

What would that change? The problem is not where it lives, the problem is that we moved to gfx-hal long ago (3 years by now?), and we don't want to maintain the old stuff any more. If there are people who are interested, we can chat (care to jump on #gfx:matrix:org? or anywhere else, really), and we'll figure out how to let you maintain it.