[WebGL] Fix index buffer usage

gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.

http://gfx-rs.github.io/

Apache License 2.0

5.35k stars 549 forks source link

[WebGL] Fix index buffer usage #3682

Closed Gordon-F closed 3 years ago

Gordon-F commented 3 years ago

Fixes #3669 PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[x] tested examples with the following backends: WebGL/OpenGL

Currently, the problem is not fully resolved:

kvark commented 3 years ago

At least the index buffer works now? 🎉

Gordon-F commented 3 years ago

At least the index buffer works now?

Yes, now we can allocate an index buffer and send data to it. But I don't know why this buffer also used for other data even if it doesn't have Usage::TRANSFER_SRC flag.

Gordon-F commented 3 years ago

@kvark Texture problem seems unrelated to buffer usage. I'm trying to investigate what's wrong. Anyway index buffer fix should be ready to merge.

bors[bot] commented 3 years ago

Merge conflict.

kvark commented 3 years ago

Still CI errors

Gordon-F commented 3 years ago

Still CI errors

Sorry, should be fixed now! But looks like CI is stuck 🤔

kvark commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: