Update naga to gfx-18 - Githubissues

gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.

http://gfx-rs.github.io/

Apache License 2.0

5.35k stars 551 forks source link

Update naga to gfx-18 #3695

Closed Gordon-F closed 3 years ago

Gordon-F commented 3 years ago

When trying to update my dev environment to the latest naga, I saw that api changes a little bit. This PR update to latest available naga (a0b5717fed0bd1c8536fb2204f308d6db39d295f)

Hope this will be helpful 😄

PR checklist:

[ ] make succeeds (on *nix)
[ ] make reftests succeeds
[x] tested examples with the following backends: OpenGL

kvark commented 3 years ago

Thank you! Let's release a naga tag after https://github.com/gfx-rs/naga/pull/608 merges in. For your code, I think we need to disable all validation in gfx's use of Naga. gfx-rs is meant to be totally unsafe, so there is no need to do extra work at this stage. In all the places where you use ValidationFlags, it should be ValidationFlags::empty().

kvark commented 3 years ago

@Gordon-F gfx-18 tag is published now, please use it Edit: sorry, I discovered https://github.com/gfx-rs/naga/pull/610 and promptly removed the tag. Will tag tomorrow once this fix lands.

kvark commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: