search

gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.
http://gfx-rs.github.io/
Apache License 2.0
5.35k stars 548 forks source link

Enable VK_KHR_storage_buffer_storage_class on VK-1.0 #3700

Closed kvark closed 3 years ago

kvark commented 3 years ago

This is required for the next Naga update, see https://github.com/gfx-rs/naga/pull/612

Gordon-F commented 3 years ago

Is SPIR-V 1.3 required Vulkan 1.1 ?

Based on Android distribution dashboard this requirement drops 22.0% of Vulkan based devices. Also based on gpuinfo.org information VK_KHR_storage_buffer_storage_class not supported on 23.7% devices.

kvark commented 3 years ago

yes, Vulkan 1.1 requires SPIR-V 1.4. I'm told that pretty much everything under the sun either supports the extension, or Vulkan 1.1

Gordon-F commented 3 years ago

I'm told that pretty much everything under the sun either supports the extension, or Vulkan 1.1

Maybe my point looked too scary (drops 23% of Android devices), but after I open my link again I realized that only 19 devices don't support VK_KHR_storage_buffer_storage_class 😄

Is this an urgent task? Can I try to solve it?

kvark commented 3 years ago

Please do! This is a little bit urgent in a sense that it's going to block the next naga train (gfx-19), which we aren't doing yet. We haven't fully got gfx-18 arriving to wgpu-rs yet, even.