gfx-rs / gfx

[maintenance mode] A low-overhead Vulkan-like GPU API for Rust.
http://gfx-rs.github.io/
Apache License 2.0
5.35k stars 551 forks source link

Remove Naga preference setting from GL and Metal #3747

Closed kvark closed 3 years ago

kvark commented 3 years ago

Follow-up to #3641 Our code paths are more complex that they should be. Duplicating the Naga path both before and after the Cross, depending on the preference, is not needed by anybody. Now that Naga has matured quite a bit, we need to be more aggressive. I believe this PR preserves the old behavior (minus fallback from Cross to Naga), but cleans up the code. It also avoids unnecessary work (naga parsing of SPIR-V) if Cross is enabled. PR checklist:

kvark commented 3 years ago

bors r+

bors[bot] commented 3 years ago

Build succeeded: