Closed bsekura closed 3 years ago
Please use "Resolve Conversation" on items that are addressed, so that we know when it's time to look at the code again.
@bsekura what's the status? Is it waiting for re-review of some points, or all ready?
That should do it for now. Please check and merge if there are no issues. Sorry, I was unavailable for a bit and it took longer than expected.
I'm on it. Squash via rebase is giving me a headache because of merge with upstream. Are you able to merge and squash on your end using github's features?
This is another pass of adding new macOS 11.0 features to metal-rs. It lays some groundwork to add new ray tracing API, as well as adding things like dynamic libraries, function pointers, etc. Some naming changes were also made.
This is still work in progress, but I wanted to merge as I go to avoid drifting too much. There are some comments left for things yet to be done.
I also added a simple example of using shader dynamic libraries.
I expect some discussion and cleanup, so I will squash commits once we're all happy with this PR.