search

gfx-rs / metal-rs

Rust bindings for Metal
Apache License 2.0
591 stars 112 forks source link

Add MPSMatrix and related classes #217

Closed yumios closed 3 years ago

yumios commented 3 years ago

Add some classes to be able to calculate matrix multiplication on metal. And add an example that executes matrix multiplication commands.

kvark commented 3 years ago

This is a part of the Metal performance shaders, right? What volume of the API surface are we considering here? I think we discussed it briefly in the past, and I suggested to have the MPS in a separate library that depends on metal-rs, like metal-perf-shaders or something. But I haven't really used it, so open to opinions!

yumios commented 3 years ago

Sorry for not knowing that you already suggested having the MPS in a separate library. I'm going to add various MPS features about MPSCNN and MPSMatrix to use in my applications. So, I agree with your idea because MPS looks too huge to add to metal-rs and I feel it isn't often used by existing metal-rs users. I'll close this PR and write a new library for binding MPS API. Thank you for your feedback! It helped me a lot.

kvark commented 3 years ago

Thank you! Looking forward to see this emerging:)

On Jun 30, 2021, at 13:59, Yumikiyo Osanai @.***> wrote:

 Closed #217.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.