search

gfx-rs / metal-rs

Rust bindings for Metal
Apache License 2.0
567 stars 112 forks source link

add `presented_time` to `Drawable` #300

Closed marcpabst closed 3 months ago

marcpabst commented 8 months ago

https://developer.apple.com/documentation/metal/mtldrawable/2806855-presentedtime

In preparation for https://github.com/gfx-rs/wgpu/issues/2869.

MarijnS95 commented 8 months ago

Good to mention that this PR depends on #298, which should be (squash-)merged first.

marcpabst commented 8 months ago

Yep - sorry! Never submitted a PR that supersedes another one and was under the impression that GitHub keeps track of that automatically.

MarijnS95 commented 8 months ago

@marcpabst no worries! GitHub doesn't have any support for this at all, so a little hint in the PR description for maintainers is the least one can do (there's a finicky trick with target branches but it doesn't work across forks and is super fragile).

Note also that you don't need to create a PR on your local fork to incorporate another change as a base - pro-tip for next time :+1:

grovesNL commented 3 months ago

Just rebasing this, will merge in a minute