kvark commented 6 years ago

Depends on https://github.com/gfx-rs/gfx/pull/2202 cc @fkaa

kvark commented 6 years ago

As discussed on Gitter: Bors r=msiglreith

On Jul 3, 2018, at 16:36, msiglreith notifications@github.com wrote:

@msiglreith commented on this pull request.

In libportability-gfx/src/impls.rs:

pso::AllocationError::OutOfDeviceMemory => VkResult::VK_ERROR_OUT_OF_DEVICE_MEMORY,

pso::AllocationError::OutOfPoolMemory => VkResult::VK_ERROR_OUT_OF_POOL_MEMORY_KHR,

pso::AllocationError::IncompatibleLayout => VkResult::VK_ERROR_DEVICE_LOST,

pso::AllocationError::FragmentedPool => VkResult::VK_ERROR_FRAGMENTED_POOL,

},

let mut result = VkResult::VK_SUCCESS;

assert_eq!(descriptor_sets.len(), info.descriptorSetCount as usize);

for (i, raw_set) in descriptor_sets.into_iter().enumerate() {

match raw_set {

Ok(set) => {

sets[i] = Handle::new(set);

}

Err(e) => {

// revert all the changes!

for set in sets[..i].iter_mut() { What is with the other remaining sets?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

bors[bot] commented 6 years ago

gfx-rs / portability

Expose VK_KHR_maintenance1 and fix the descriptor allocation fall back #110

Build succeeded