search

gfx-rs / wgpu-rs

Rust bindings to wgpu native library
https://wgpu.rs
Mozilla Public License 2.0
1.69k stars 186 forks source link

Fix excessive buffer padding #795

Closed HalfVoxel closed 3 years ago

HalfVoxel commented 3 years ago

Previously buffers sizes which were already aligned would be unnecessarily padded with COPY_BUFFER_ALIGNMENT (4) bytes.

cwfitzgerald commented 3 years ago

With those changes, please squash and we'll be good to go.

HalfVoxel commented 3 years ago

The bot says it has found warnings and errors... but it doesn't seem to show them? Is it configured correctly?

HalfVoxel commented 3 years ago

@kvark, done. Squashing I believe can be done by github directly when merging. image

Btw, locally I'm getting a ton of clippy errors for other parts of the code, am I using the wrong clippy config?

kvark commented 3 years ago

Squashing I believe can be done by github directly when merging.

Wee use a merge bot which doesn't know how to squash. I can squash manually though if I see no other PRs are in flight

kvark commented 3 years ago

Btw, locally I'm getting a ton of clippy errors for other parts of the code, am I using the wrong clippy config?

We aligned naga and wgpu to respect clippy warnings/errors, but not gfx-rs or wgpu-rs yet. This would be nice to get!