gfx-rs / wgpu

A cross-platform, safe, pure-Rust graphics API.
https://wgpu.rs
Apache License 2.0
11.46k stars 855 forks source link

refactor: `vertex_index_common`: remove footguns in `tests` matrix init. #5840

Closed ErichDonGubler closed 6 days ago

ErichDonGubler commented 1 week ago

Connections

Addresses non-blocking feedback raised in https://github.com/gfx-rs/wgpu/pull/5773 (1, 2).

Description

Remove a couple of footguns around allocation and exhaustive matrices for tests using the vertex_index_common helper.

Testing

I've used assert_eq!(…) checks between new and old values (not committed here) to ensure that we haven't regressed, so I feel fairly confident. 🙂 Attached: test.zip

Checklist

jimblandy commented 4 days ago

Sorry about the confusion - I didn't realize this PR was against vertexPullByDefault and not trunk.