gfx-rs / wgpu

A cross-platform, safe, pure-Rust graphics API.
https://wgpu.rs
Apache License 2.0
12.72k stars 933 forks source link

Add missing validation for timestamp writes in render and compute passes #6578

Closed ErichDonGubler closed 14 hours ago

ErichDonGubler commented 1 day ago

Connections

-

Description

It turns out, no validation for timestamp writes' indices or even query type was present. Holy crap! Fix that plz. Apply all validation that the WebGPU spec. specifies in:

Testing

Checklist

ErichDonGubler commented 14 hours ago

@Wumpf:

unit test would be nice :)

Filed https://github.com/gfx-rs/wgpu/pull/6584 to follow up with it, and updated the OP.