It turns out, no validation for timestamp writes' indices or even query type was present. Holy crap! Fix that plz. Apply all validation that the WebGPU spec. specifies in:
webgpu:api,validation,encoding,beginComputePass:timestampWrites,invalid_query_set:querySetState="invalid" is specifically resolved by #6579.
Deferred webgpu:api,validation,encoding,beginComputePass:timestampWrites,query_index: beginningOfPassWriteIndex="_undef_";endOfPassWriteIndex="_undef_" to https://github.com/gfx-rs/wgpu/pull/6583.
Connections
-
Description
It turns out, no validation for timestamp writes' indices or even query type was present. Holy crap! Fix that plz. Apply all validation that the WebGPU spec. specifies in:
GPUCommandEncoder.beginRenderPass
, step 10 on the device timelineGPUCommandEncoder.beginComputePass
, step 4 on the device timelineTesting
webgpu:api,validation,encoding,beginComputePass:timestampWrites,*
webgpu:api,validation,encoding,beginComputePass:timestampWrites,invalid_query_set:querySetState="invalid"
is specifically resolved by #6579.webgpu:api,validation,encoding,beginComputePass:timestampWrites,query_index: beginningOfPassWriteIndex="_undef_";endOfPassWriteIndex="_undef_"
to https://github.com/gfx-rs/wgpu/pull/6583.webgpu:api,validation,encoding,beginRenderPass:occlusion_query_set,device_mismatch:*
webgpu:api,validation,encoding,beginRenderPass:timestamp_query_set,device_mismatch:*
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
--target wasm32-unknown-emscripten
cargo xtask test
to run tests.CHANGELOG.md
. See simple instructions inside file.