Calibration

[paramhanji]

The lightweight calibration tool for Meta's internal release. We don't have to merge just yet. I created a pull request to easily keep track of changes.

Let me know if we need any changes/improvements.

[mantiuk]

The current code checks first in the dir specified in the '--config-dir', then it check the default location. So it should work.

Rafal

On Wed, Mar 8, 2023 at 12:52 PM Param Hanji @.***> wrote:

@.**** commented on this pull request.

In calibration/README.md https://github.com/mantiuk/ColourVideoVDP/pull/2#discussion_r1129311753:

+## Step 1: Prepare quality CSV +Create a .csv file with the following mandatory columns: +1. test - test filename +2. ref - reference filename +3. jod - ground-truth quality in JOD units (typically obtained by running a subjective experiment). + +A few optional columns may also be included: +1. display - per-condition display model; use this if each row requires a separate display model (photometric or geometric) + +[Header]: The file may include an optional header containing argparse options. These options will be parsed by our script and will supersede default as well as CLI arguments. See this example file for more details. + +## Step 2: Extract features +Run the script extract_features.py with a single mandatory argument - the .csv file from the previous step. Additional arguments may be passed directly or included in the Header of the .csv file. Run -h/--help to obtain descriptions for all arguments. + +## Step 3: Run training +Run the script train.py, again with a single mandatory argument - the same .csv file used to extract features. The result of calibration is a new configuration JSON file provided by argument --output_file (default value is "new_parameters.json"). Replace the original file with this file to use the calibrated parameters.

Got it.

An issue I foresee is that vvdp_data https://github.com/mantiuk/ColourVideoVDP/tree/calibration/pycvvdp/vvdp_data contains many other files (colorspace, some LUTs, display config, etc.). If we update "config-dir", won't we lose access to these? Do we need to replicate all of it?

— Reply to this email directly, view it on GitHub https://github.com/mantiuk/ColourVideoVDP/pull/2#discussion_r1129311753, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADVYK4VZ7AVY6SW2QROGTFTW3BXHHANCNFSM6AAAAAAVPQVZKY . You are receiving this because your review was requested.Message ID: @.***>

[paramhanji]

Thanks for the suggestions, Rafal. I have addressed most of them, could you have another look? I have resolved the obvious ones that have been addressed.

The only difference is in handling absolute paths and extensions. You recommended having complete paths with extensions for each row under "test" and "reference". My current solution is to indicate "path-prefix" and "extension" at the beginning of the file (see https://github.com/mantiuk/ColourVideoVDP/blob/calibration/calibration/xr-david.csv)

[paramhanji]

I removed the "extension" argument in the latest commit.