gfxdisp / ColorVideoVDP

Colour video VDP
MIT License
29 stars 6 forks source link

pycvvdp: Sort the output for wildcharchars #9

Closed vibhoothi closed 4 months ago

vibhoothi commented 4 months ago

This is problematic if we do not sort when we feed two folders. Python does not care about frame orders, but we care, so in some cases, it was comparing Frame 2 with Frame 90. So to be correct, we sort it before returning the list.

PS: Will rebase once #7 is merged

vibhoothi commented 4 months ago

What do you mean duplicate functionality of save? Save was introduced in this PR, not sure about duplicate functionality, there was no way to save as csv in the path.

I think interactive mode is orthogonal to this PR.

We can always kill pandas if we need, it will be useful if you prefer to match like how modern tools work which supports CSV/XML/JSON and others. So it can be easy adjusted, while if we use classic CSV/filebased IO, it will be harder to support more output formats in future, See VMAF tool for reference of multi output format

vibhoothi commented 4 months ago

I also see you have https://github.com/gfxdisp/ColorVideoVDP/commit/b854cfcfed38d2936908eed57687ee830d0aba2f which is essentially this PR commit https://github.com/gfxdisp/ColorVideoVDP/pull/9/commits/f0814276597f52d8946849eb424c4eddebbe3b87 but a copy of it without reference to the original commit;)

Edit: would be better if it commits are cherrypicked for original authors than copying relevant lines and applying

mantiuk commented 4 months ago

Yes, sorry, I missed https://github.com/gfxdisp/ColorVideoVDP/commit/f0814276597f52d8946849eb424c4eddebbe3b87

We will look into how to unify the interface with VMAF at some point. But this will be a separate PR.

Right now, you can use --quiet argument to get the JOD scores alone.

vibhoothi commented 4 months ago

https://github.com/gfxdisp/ColorVideoVDP/commit/b854cfcfed38d2936908eed57687ee830d0aba2f addresses this