search

ggPMXdevelopment / ggPMX

ggPMX R package
37 stars 11 forks source link

vpc: plots don't cover the whole range of observed time #154

Closed biencan1 closed 2 years ago

biencan1 commented 3 years ago

Describe the bug VPC plots don't cover the whole range of time variable on x-axis. Depending on the binning method used they either cut the observations around start (time>=0) or at the end of observational period. Here's an example of a plot generated in ggPMX: image

And a plot generated in Monolix: image

Also binning is suboptimal.

To Reproduce I can provide code and datasets to reproduce provided plots

Package and platform (please complete the following information): image

biethbr1 commented 3 years ago

@tynesjo: can you look at the ggPMX code to understand if there is selection performed by ggPMX to select the range of x-axis?

tynesjo commented 3 years ago

Issue reproduced.

The plot attached additionally has individual observations shown: they do cover an x axis range which extends beyond that of the median and percentiles lines.

vpc-w-indidividual

baltcir1 commented 3 years ago

Hi Johannes,

Thanks for working on this. I suppose the areas span from the middle of the first bin to the middle of the last bin (something like that). There is also an option in the VPC plot to display ticks that show the bins. That may also help to identify the problem.

Best, Irina

From: Johannes Tynes notifications@github.com Sent: Monday, 8 February 2021 09:57 To: ggPMXdevelopment/ggPMX ggPMX@noreply.github.com Cc: Baltcheva, Irina irina.baltcheva@novartis.com; Assign assign@noreply.github.com Subject: Re: [ggPMXdevelopment/ggPMX] vpc: plots don't cover the whole range of observed time (#154)

Issue reproduced.

The plot attached additionally has individual observations shown: they do cover an x axis range which extends beyond that of the median and percentiles lines.

[vpc-w-indidividual]https://urldefense.proofpoint.com/v2/url?u=https-3A__user-2Dimages.githubusercontent.com_3072895_107197220-2D871d2f80-2D69eb-2D11eb-2D99a7-2Da27628a41db9.png&d=DwMCaQ&c=ZbgFmJjg4pdtrnL2HUJUDw&r=aKykINevLIXBb2-gHmhroKGVY88hh9HCgL0YAgz8yzg&m=qthTIfAVyOodWGCAns1sEIFY8b7JeWxx-RBLAinve7M&s=yc4Xa78z8LpNI4eF5p0wTu3g-ViJW9YM4aJqqM3R48o&e=

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ggPMXdevelopment_ggPMX_issues_154-23issuecomment-2D774984703&d=DwMCaQ&c=ZbgFmJjg4pdtrnL2HUJUDw&r=aKykINevLIXBb2-gHmhroKGVY88hh9HCgL0YAgz8yzg&m=qthTIfAVyOodWGCAns1sEIFY8b7JeWxx-RBLAinve7M&s=rX9pUtsN5Ft3ASZptP6yfbQ96QIiU37j5A2cI6G-2Ec&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AGCGRLFB4XF6MJPSAQPGAILS56RN3ANCNFSM4UGUOMOQ&d=DwMCaQ&c=ZbgFmJjg4pdtrnL2HUJUDw&r=aKykINevLIXBb2-gHmhroKGVY88hh9HCgL0YAgz8yzg&m=qthTIfAVyOodWGCAns1sEIFY8b7JeWxx-RBLAinve7M&s=zLZ4smqYx-dAHHpEeY4WdXkNe0lS4SEfggTmzOtLJ-Y&e=.

baltcir1 commented 2 years ago

Problem can be solved by adding an additional bin. I suggest closing this issue.