Freeing scales on a facetted plot does not work

ggPMXdevelopment / ggPMX

ggPMX R package

37 stars 11 forks source link

Freeing scales on a facetted plot does not work #259

Open biencan1 opened 2 years ago

biencan1 commented 2 years ago

Facet argument should be taking over parameters from facet_wrap but freeing scales does not work. Example below:

ctr %>% pmx_plot_dv_pred(bloq=pmx_bloq(cens="BLOQ",colour="blue",size=1),
                         use.abbrev = TRUE,
                 is.draft=FALSE,
                         strat.facet = ~TRT,
                 facets=list(scales="free",nrow=1),       #scales doesn't work with this faceting 
                         labels=list(title="DV vs PRED by dose"))

Produces:

Generated with ggPMX 1.2.8

tynsci commented 2 years ago

issue has been reproduced
it has been possible to identify what the source of the error is
it does not relate to the arguments to facet_wrap not being passed through, but rather that they do not take effect
the reason they do not take effect is that coord_cartesian is used prior to the scales="free" argument of facet_wrap being applied
- this takes place in the plot_pmx.residual function
a fix is in progress

tynsci commented 1 year ago

works now subject to pull request #278

mattfidler commented 1 year ago

This was accidently closed by me because I accidently merged the Pull request #278. As I mentioned to @tynesjo we cannot use internal ggplot2 functions even if they fix the problem. This would not be accepted by CRAN. It violates their policies.