Review Tomas: pmx_plot_dv_ipred, etc. cannot handle both strat.color and other point aesthetic parameters

[tmss1]

Describe the bug For pmx_plot_dv_pred, pmx_plot_dv_ipred, pmx_plot_npde_pred, pmx_plot_npde_time, and likely other related plots, if strat.color and point=... for geom point aesthetics are both used, only strat.color is preserved.

For example, alpha for points was lost when strat.color was added:

[tynsci]

thanks for reporting @tmss1

Status

• it has been possible to reproduce this bug
• the source of the error has been identified and a fix has been made

Next

• pull request forthcoming once testing has been completed

[tmss1]

Not only is this not working in the latest development version yet, now even the argument strat.color has stopped working, which was at least able to plot colours by group. It is no longer working now and generate the same plot with or without.

ctr %>% pmx_plot_dv_pred()

ctr %>% pmx_plot_dv_pred(strat.color="HEM") # No colour!