ggarra13 / mrv2

Professional player and review tool for vfx, animation and computer graphics.
https://mrv2.sourceforge.io
BSD 3-Clause "New" or "Revised" License
197 stars 14 forks source link

FR: Save images to predefined folder #167

Closed gerroon closed 9 months ago

gerroon commented 9 months ago

Hi

it would be great if one could just capture individual frames to a predefined folder like that can be done with VLC. It isa bit tedious to constantly enter individual file names for saving single frame.

ggarra13 commented 9 months ago

I've added File->Save->Frames to Folder to v0.9.4 beta currently on sourceforge.net (https://sourceforge.net/projects/mrv2/files/beta/).

The first time you call the function, it will ask you the parameters and the directory and name to save the file as usual. However, the next times you invoke it, it will automatically save the image without popping any options or file name.

To change the file name or options that it is saving under, you should go to File->Save->Single Frame as usual and then go on to keep using File->Save->Frames to Folder.

gerroon commented 9 months ago

Thanks, it crashed when I did not provide a file extension.

How do I set the actual frame number?

Also it keeps opening the folder browser, then I am manually saving every time I pres "alt-s" which I set to be save single frame. I do not see it saving in hte background like VLC does.

"rv2 64 bits - v0.9.4 - Built Dec 11 2023 08:22:19 With msvc 1929 (C) 2022-Present Film Aura, LLC. Gonzalo Garramuño & others

mrv2 depends on:

Boost v1.76.0 Copyright (c) 2016-Present Contributors to the Boost Project "

ggarra13 commented 9 months ago

Just save a filename like test.0001.tga or test.0001.exr. Just test.exr should work too (it will be renamed as test0001.exr IIRC). If you have a movie file, you may need to set Annotations to on to save EXRs.

The number will be added automatically based on the frame you are in. So, it won't save them in sequence (like 1,2,3,4), but with the original frames, which I think is more useful.

gerroon commented 9 months ago

It does not work on Windows 11, as far as I can tell.

Exr trows error

ERROR: [save] D:/.TMP/test.0001.exr: Unsupported video

gerroon commented 9 months ago

image

As you see the frame number is not saved

image

ggarra13 commented 9 months ago

It does not work on Windows 11, as far as I can tell.

Exr trows error

ERROR: [save] D:/.TMP/test.0001.exr: Unsupported video

This is the error you get when you don't have Annotations on. Movie files are encoded in 8-bits YUV which EXRs do not support. Turning ON Annotations on makes the frame be captured in RGBA_F32 which is compatible with EXRs.

ggarra13 commented 9 months ago

Thanks, it crashed when I did not provide a file extension.

Thanks, I'll check that, as it is likely a bug.

ggarra13 commented 9 months ago

Thanks, it crashed when I did not provide a file extension.

Thanks, I'll check that, as it is likely a bug.

I checked both File->Save->Single Frame and File->Save->Frames to Folder. With either one when I save with no extension, I get the following error:

ERROR: [cback] File extension cannot be empty.

You will need to give me step by step instructions to reproduce it.

ggarra13 commented 9 months ago

Also it keeps opening the folder browser, then I am manually saving every time I pres "alt-s" which I set to be save single frame. I do not see it saving in hte background like VLC does.

You should not set the shortcut to "Save Single Frame" (which does exactly what it says it does), but to "Save Frames to Folder".

gerroon commented 9 months ago

Also it keeps opening the folder browser, then I am manually saving every time I pres "alt-s" which I set to be save single frame. I do not see it saving in hte background like VLC does.

You should not set the shortcut to "Save Single Frame" (which does exactly what it says it does), but to "Save Frames to Folder".

Thanks for the addition, that was it.