search

ggarra13 / mrv2

Professional player and review tool for vfx, animation and computer graphics.
https://mrv2.sourceforge.io
BSD 3-Clause "New" or "Revised" License
197 stars 14 forks source link

Gain and gamma controls before applying Display/View #171

Closed jrsndl closed 7 months ago

jrsndl commented 9 months ago

It is great to be able to adjust Gamma and Gain controls before applying Display/View to the image. If that would invalidate the cache, maybe making it optional? Very useful for tech-checking shots for example.

Thank you

ggarra13 commented 9 months ago

It is great to be able to adjust Gamma and Gain controls before applying Display/View to the image. If that would invalidate the cache, maybe making it optional? Very useful for tech-checking shots for example.

AFAIK, gamma and gain are adjusted before OCIO. Do you see it happening otherwise? That might be a bug.

Currently the order of shaders is hard-coded in tlRender code. If you need flexibility from switching from sometimes applying them before and other times applying them after, you should add a feature request with Darby Johnston at:

https://github.com/darbyjohnston/tlRender/issues

If it is a feature you need right now you may want to look into OpenRV which has a completely flexible shader pipeline.