search

ggarra13 / mrv2

Professional player and review tool for vfx, animation and computer graphics.
https://mrv2.sourceforge.io
BSD 3-Clause "New" or "Revised" License
197 stars 14 forks source link

Too sensitive "Alt + Right Click" Zoom #178

Closed bouncyferret closed 7 months ago

bouncyferret commented 8 months ago

Hi I find that the Alt + Right Click zoom feature is a bit too sensitive/hard to use at the moment. It's often impossible to zoom back in - ending up in the void

https://github.com/ggarra13/mrv2/assets/35593504/4b49a078-05b3-46c3-b450-59c4bcb2e621

This is running on Linux/Arch/X11/Nvidia

ggarra13 commented 8 months ago

The main and beta branch in the repository have a slower zoom fix. You can also further control the sensitivity with Preferences->View Window->Zoom Speed.

If you have a new distro (compatible with Ubuntu 20.04 LTS or later), you can download the latest beta from the mrv2 sourceforge site at:

https://sourceforge.net/projects/mrv2/files/beta/

bouncyferret commented 8 months ago

I tried the beta branch on my windows partition, and while the speed setting is a great addition I still feel like it's hard to control the zoom. I recorded a video comparing it with mplay.

Some observations:

  1. Feels like there is some kind of acceleration curve applied to the zoom amount
  2. It has a tendency to suddenly jump in zoom level (acceleration?)
  3. It likes to drift to away from what I want to zoom into

Would it be possible to have it zoom to the cursor? I think it would be easier to control if the "pivot" was locked for each zoom operation.

https://github.com/ggarra13/mrv2/assets/35593504/b1493777-232b-4593-96e7-80aaa5180b57

BigRoy commented 8 months ago

It looks like as you zoom in/out the "zoom direction" (where it wants to zoom out to or from) updates along with the drag, but it should instead pick the zoom target point at the start (on click) and zoom in that direction in/out continuously.

The auto-updating of zoom direction/target point is what makes zoom out so hard because as soon as you go wider than the image your zoom out point is outside of the image (but likely still right of center of the view) and you get massive amounts of zoom out making it behave almost exponentially.

ggarra13 commented 8 months ago

Would it be possible to have it zoom to the cursor? I think it would be easier to control if the "pivot" was locked for each zoom operation.

In case you missed it, I uploaded a much better fix to do this in the beta folder of sourceforge.net.

It should work on Windows 8.1+ (without USD), Ubuntu 20.04+ and macOS 11.0+.

bouncyferret commented 8 months ago

Ah! I did miss that. This is fantastic - feels great to use! Thanks!

One final wish would be to have a even slower zoom speed option, as I'm using a tablet even the slow option feels fast 🏎️

https://github.com/ggarra13/mrv2/assets/35593504/2a53de06-235c-430c-8442-35f8c876a77c

ggarra13 commented 7 months ago

I've upload one other beta try to sourceforge.net for Windows 8.1+ and Ubuntu 20.04 LTS+. macOS should be done shortly.

bouncyferret commented 7 months ago

Took it for a spin - it's perfect. Thanks a ton! This brings me such joy 🥇