search

ggascoigne / amber

https://amberconnw.org
MIT License
3 stars 0 forks source link

No Game and Any Game game_ids are different for ACUS and ACNW and make queries fragile #109

Closed evoskamp closed 1 year ago

evoskamp commented 1 year ago

Move to author_id being NULL instead

ggascoigne commented 1 year ago

the author_id being null fixes the queries, but I'd like to change how those values are identified in general.

I really think that the whole magic number thing was a mistake and I should have uses a flags/type field to id the records.

evoskamp commented 1 year ago

Yeah, there's just no way to argue against that. :-)

Magic numbers, overloading identifiers, and having identifiers have structured meaning always comes back to bite you in the ass.

the author_id being null fixes the queries, but I'd like to change how those values are identified in general.

I really think that the whole magic number thing was a mistake and I should have uses a flags/type field to id the records.