search

ggascoigne / amber

https://amberconnw.org
MIT License
3 stars 0 forks source link

playerMin / playerMax should move to settings #160

Open evoskamp opened 9 months ago

evoskamp commented 9 months ago

packages/amber/views/Games/GamesDialog.tsx/getDefaultValues # 91

playerMin: configuration.virtual ? 2 : configuration.numberOfSlots === 8 ? 3 : 4, playerMax: configuration.virtual ? 7 : configuration.numberOfSlots === 8 ? 6 : 10,

Moving to configuration values

evoskamp commented 9 months ago

Adding

playerMin: toNumber(), playerMax: toNumber(), playerMinVirtual: toNumber(), playerMaxVirtual: toNumber(),

evoskamp commented 9 months ago

On second thought, no reason to add playerMinVirtual and playerMaxVirtual: we can always update playerMin and playerMax if we go virtual