ggascoigne / amber

https://amberconnw.org
MIT License
3 stars 0 forks source link

Ev/issue 73 download gamechoices report #75

Closed evoskamp closed 1 year ago

evoskamp commented 1 year ago

Tested locally against ACUS and ACNW.

Report and report config not ported to ACNW.

Changes as is for ACUS require a role 'ROLE_PLAYER_ADMIN' :

INSERT INTO ROLE (id, authority) VALUES(6,'ROLE_PLAYER_ADMIN')

Other changes allow an optional perm on the ReportRecord in report-admin.tsx.

Reports.tsx has some severe TypeScript stupidity that's my stupidity as adding the condition on line 45 as an additional compound test to the filtering on line 35 (where it belonged), or even as a tertiary operator within the return just did not like me. This works. I'm going to call it good and take a nap. (also, obviously, feel free to fix it). I'll look at it again after pulling members, games, and game choices and get them in the format my scheduling spreadsheet uses.

Cheers

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
amber-acus ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 4:07AM (UTC)
amberconnw ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 4:07AM (UTC)