search

ggb / numeral-elm

Numeral.js port to Elm
MIT License
22 stars 9 forks source link

Upgrade to Elm 0.19 #15

Closed wmakley closed 6 years ago

wmakley commented 6 years ago

I rely on this library, so I'm working on an upgrade on a fork. (Please let me know if redundant.) I'm keeping the style intact (and not elm-formatting it), just making the minimally necessary changes. The biggest issue is the Regex package API changed a lot. Everything else was a minor change.

ggb commented 6 years ago

I've just pushed the changes for 0.19. At the moment I'm not able to update the library on elm-package, because of issues with elm-test. As soon as I've solved these issues, I'll publish the new version.

Thanks for your work!

wmakley commented 6 years ago

Awesome, thanks! Really appreciate this library.

ggb commented 6 years ago

I was finally able to run the tests and fix issues, that (of course) popped up. But now everything is fine again and the new version is published to elm-package. Please let me know, if you run into any issues.