search

ggb / numeral-elm

Numeral.js port to Elm
MIT License
22 stars 9 forks source link

update for elm 0.17 #3

Closed alex-kovshovik closed 8 years ago

alex-kovshovik commented 8 years ago

I've updated both the package and its tests - they pass!, however tests now don't use Graphics.Element, since elementRunner got removed from elm-community/elm-test.

I tested breaking one of the tests and the result look like this:

6 suites run, containing 69 tests
4 suites and 68 tests passed
2 suites and 1 tests failed

Test Suite: Numeral: FAILED
Test Suite: Tests for numbers: all tests passed
Test Suite: Tests for currency: FAILED
"$1,000.23" == "$1,000.23": passed.
"$ 1,001" == "$ 1,001": passed.
"1,000.23 $" == "1,000.23 $": passed.
"($1,000)" == "($1,000)": passed.
"(1,000$)" == "(1,000$)": passed.
"-$1000.23" == "-$1000.23": passed.
"$1.23 m" == "$1.23 m": passed.
"$ (1,000)" == "$ (1,000)": passed.
"$(1,000)" == "$(1,000)": passed.
"$ (1,000.23)" == "$ (1,000.23)": passed.
"$(1,000.232)" == "$(1,000.23)": FAILED. Expected: "$(1,000.232)"; got: "$(1,000.23)"
"$(1,000.24)" == "$(1,000.24)": passed.
"$-1,000" == "$-1,000": passed.
"$ -1,000" == "$ -1,000": passed.
"$ 1,000" == "$ 1,000": passed.
"$1,000" == "$1,000": passed.
"$ 1,000.23" == "$ 1,000.23": passed.
"$1,000.23" == "$1,000.23": passed.
"$1,000.24" == "$1,000.24": passed.
"$1,000" == "$1,000": passed.
"$ 1,000" == "$ 1,000": passed.
Test Suite: Tests for bytes: all tests passed
Test Suite: Tests for percentages: all tests passed
Test Suite: Tests for time: all tests passed
ggb commented 8 years ago

I've double checked that everything works as expected and updated the package to 0.17 on elm-package. Thanks so much!