JOSS REVIEW: Examples - Githubissues

rbeucher commented 2 years ago

[ ] Please consider merging README markdown files and PYTHON scripts into a Jupyter notebook. They are easier to read, especially on GitHub. You can also take the user through the step of installing the required Python dependencies...
[ ] Please don't expect user to have PETSc installed in their HOME directory as default...
[ ] Jupyter notebooks would also help to visualize the outcome of the models / Benchmarks. As it is now, users must run the model themselves to see the result and they don't have a mean of comparison. That is also where you should compare with other codes (I2VES, UNDERWORLD, STAGYY)

rbeucher commented 2 years ago

I see the Benchmarks results are in the documentation. That's good. I would like to have them in some Jupyter notebooks as well.

rbeucher commented 2 years ago

Thanks for doing this. It's much better now.

ggciag / mandyoc