JOSS REVIEW: Model progression is hard to track

ggciag / mandyoc

MANDYOC is a finite element code written on top of the PETSc library to simulate thermo-chemical convection of the Earth's mantle

https://ggciag.github.io/mandyoc/

BSD 3-Clause "New" or "Revised" License

27 stars 5 forks source link

JOSS REVIEW: Model progression is hard to track #49

Closed rbeucher closed 2 years ago

rbeucher commented 2 years ago

I am running the examples. All seems to go as expected. However, I find it really hard to track progress of the model. Can you add a step number, time evolution etc?

rbeucher commented 2 years ago

OK I see now:

step = 6, time = 5.08e+04 yr, dt = 8.46e+03 yr
Thermal (building): 0.239868 s
Thermal (solution): 0.049435 s

Still hard to understand what the code is doing. If it is iterating on a solve etc.

Maybe try to clarify that?

victorsacek commented 2 years ago

During the simulation, we added a few sentences to facilitate the reading of the model progression.