search

ggciag / mandyoc

MANDYOC is a finite element code written on top of the PETSc library to simulate thermo-chemical convection of the Earth's mantle
https://ggciag.github.io/mandyoc/
BSD 3-Clause "New" or "Revised" License
27 stars 5 forks source link

JOSS REVIEW: Tests #53

Closed rbeucher closed 2 years ago

rbeucher commented 2 years ago

For now your submission does not have automated tests. Please consider adding some basic tests. Maybe run tutorials and/or examples.

rafaelmds commented 2 years ago

We changed the tests to run a simplified version of examples.

We also configured a workflow (github action) to run the tests automatically using the docker image.

But, since we have a time limit on github actions we will need to adjust the strategy to run the tests to cpu compute time. We are thinking to use CircleCI since it has a higher cpu time quota.

You can check the results of the test action here.

Merged on #68.

rbeucher commented 2 years ago

Thanks @rafaelmds.