ggebbie / ECCOtour.jl

Take a self-guided tour of the ECCO version 4 release 4 ocean reanalysis product.
MIT License
1 stars 0 forks source link

Understanding rotate_uv #54

Closed anthony-meza closed 1 year ago

anthony-meza commented 2 years ago

The rotate_uv function is not identical to the UVtoUEVN in MeshArrays.jl. However, rotate_uv obeys conservation of volume better than UVtoUEVN. One main difference is that UVtoUEVN interpolates the velocities to the grid center before rotating. Whether or not this a necessary step is still in question.

ggebbie commented 2 years ago

rotate_velocity!: it does center the velocity then rotate it.

https://github.com/ggebbie/ECCOtour.jl/blob/main/src/ECCOtour.jl#L1780

But does it conserve volume accurately enough for @anthony-meza ?

ggebbie commented 1 year ago

Hope this one is good enough to close. Please re-open if there is a lingering issue.