search

ggebbie / ECCOtour.jl

Take a self-guided tour of the ECCO version 4 release 4 ocean reanalysis product.
MIT License
1 stars 0 forks source link

2d fields #73

Open cora-a-hersh opened 3 months ago

cora-a-hersh commented 3 months ago

edit ECCOtour.write() to allow processing of 2D fields

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 34.77%. Comparing base (e369ff8) to head (928fa3d).

Files Patch % Lines
src/ECCOtour.jl 0.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================== - Coverage 34.97% 34.77% -0.21% ========================================== Files 5 5 Lines 1198 1205 +7 ========================================== Hits 419 419 - Misses 779 786 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ggebbie commented 2 months ago

Thanks so much for going through the official pull request process! It looks good to me. The note from codecov above reminds me that we should write an automatic test to make sure that 1) the code works to do the new feature in a simple case and 2) that none of the previous functionality of the code is broken.