sigma-1 values different for EOS80 and JMD95

ggebbie / IsopycnalSurfaces.jl

Find isopycnal surfaces for your ocean data

MIT License

4 stars 3 forks source link

sigma-1 values different for EOS80 and JMD95 #15

Open ggebbie opened 2 years ago

ggebbie commented 2 years ago

there is an offset in the sigma-1 values calculated by the runtests.jl script. One solution: add a third equation of state (GibbsSeaWater.jl) to see which one is right (if any).

jrayshi commented 2 years ago

GibbsSeaWater.jl is added to calculate sigma. The results from GibbsSeaWater.jl is close to those from "JMD95", around 0.015-0.02% offset. The difference between "EOS80" and "JMD95" is around 0.15-0.3%. See runtest_rayEOS2.jl in test.

I have used "Gibbs" (GibbsSeaWater.jl) as the default option to calculate sigma.

ggebbie commented 2 years ago

commit https://github.com/ggebbie/IsopycnalSurfaces.jl/commit/11e2ea992e9cbc2918ebe9422ef943ac5ff36579 adds runtest_rayEOS2 to runtests. Confirmed that the EOS choices give nearly identical values.

Classic (T,S,p) arguments for TEOS10 need to be added still.