ggebbie / IsopycnalSurfaces.jl

Find isopycnal surfaces for your ocean data
MIT License
4 stars 3 forks source link

Equations of state: 1. duplicate code from other packages or 2. add package dependencies? #21

Open ggebbie opened 2 years ago

ggebbie commented 2 years ago

IsopycnalSurfaces currently duplicates (i.e., copies) code from other very helpful Physical Oceanography packages, such as

  1. https://github.com/gher-ulg/PhysOcean.jl for the EOS80 equation of state, and
  2. https://github.com/gaelforget/MITgcmTools.jl for the JMD95 equation of state.

We are especially thankful to @Alexander-Barth and @gaelforget for making these nice packages available. Of course, we'd like to credit these contributors and to make IsopycnalSurfaces better, and we'd like to know if it is preferred to include these packages as dependencies here. The question is open to these developers and the community as a whole, and can be handled publically (here) or privately.

Ideally, oceanographic equations of state would have their own dedicated package, such as GibbsSeaWater.jl. We'd also like to include the equivalent of the "seawater" toolbox in MATLAB, although we haven't found an equivalent for Julia.