Added UnitfulMatrix * Matrix functionality, small comments added

ggebbie / UnitfulLinearAlgebra.jl

Low-cost linear algebra functions for matrices with units

MIT License

6 stars 3 forks source link

Added UnitfulMatrix * Matrix functionality, small comments added #67

Closed b-r-hamilton closed 1 year ago

b-r-hamilton commented 1 year ago

I think I've resolved issue 66, please check to make sure this is an okay solution!

ggebbie commented 1 year ago

Looks like a simple PR that works well -- very nice. Adding the tests is great too. You found that the key is to multiply UnitfulMatrix with Matrix types. It doesn't work if you multiply UnitfulMatrix with AbstractMatrix because UnitfulMatrix is an AbstractMatrix and multiple dispatch algorithm becomes ambiguous.