search

ggeorg / gwt-mosaic

Automatically exported from code.google.com/p/gwt-mosaic
1 stars 0 forks source link

DefaultListModel.addAll(int, Collection) call fireContentsChanged instead of fireIntervalAdded #40

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Looking at the code of DefaultListModel, I saw that "addAll(int,
Collection)" call "fireContentsChanged" like "set(int, E)". I think calling
"fireIntervalAdded" like in "add(int, E)" will be better (or I miss
something ;-)).

Original issue reported on code.google.com by olivier....@free.fr on 12 Feb 2009 at 10:06

GoogleCodeExporter commented 9 years ago 
No, you don't miss something. Those interfaces are not ready and not very good
implemented. Until v0.2 layout managers and window panels have priority. But 
any help
and suggestions are welcome. I will think about it.

Thanks,
George.

Original comment by georgopo...@gmail.com on 12 Feb 2009 at 6:55

GoogleCodeExporter commented 9 years ago

Original comment by georgopo...@gmail.com on 12 Feb 2009 at 6:56

GoogleCodeExporter commented 9 years ago 
I have some question about "binding" to lists. There is a ListModel in the 
mosaic
project and another one in gwt-beans-binding. There are the same so I think 
it's due
to some work in progress. Which one will stay at the end?

There's also an ObservableList in gwt-beans-binding. I think we can do the same 
thing
as with ListModel. So, why ListModel and ObservableList?

If there no real reason, can we merge these all three interfaces? Which one is 
the
best to keep? (ObservableList?)

Thanks,
Olivier Monaco

Original comment by olivier....@free.fr on 27 Apr 2009 at 8:31

GoogleCodeExporter commented 9 years ago 
Hi,

the ListModel is beans binding should be a model for the simple GWT ListBox 
widget
(still work in progress). The ListModel is mosaic is used by mosaic's ListBox 
(a read
only table based on ScrollTable):

http://69.20.122.77/gwt-mosaic/Showcase.html#CwListBox

and

http://69.20.122.77/gwt-mosaic/Showcase.html#CwListBoxBinding

The ObservableList could be also used for ListModel. ListModel is more swing
oriented, like the TableModel. TableModel will be dropped and the GWT Incubator
TableModel will be used (I think there is no reason to wrap it, GWT TableModel 
has
also support for pages and inplace editors).

All this models are tested now with http://code.google.com/p/gwt-mosaic-xul/, if
ListModel will stay I will send that code to gwtx, but now as you say 
ObservableList
can do that job too (I prefer to reuse classes).

Maybe all those sounds confusing, but work with models will be done after 
version
0.2.0 and tested with gwt-mosaic-xul which will be a higher level UI framework 
based
on mosaic:

http://code.google.com/p/gwt-mosaic-xul/

a simple <listbox> with bindings:
http://code.google.com/p/gwt-mosaic-xul/source/browse/trunk/src/listbox.xml
(http://imagebin.org/47139)

and a table with a nested table model:
http://code.google.com/p/gwt-mosaic-xul/source/browse/trunk/src/table.xml
(http://imagebin.org/47140)

Kind Regards,
George.

Original comment by georgopo...@gmail.com on 28 Apr 2009 at 10:01