CellConstraints row/width functions should be static & comments fixed

[GoogleCodeExporter]

It seems like the row-column functions (i.e. rchw & friends) in
CellConstraints should be static like the xyhw functions they wrap.  Also,
their comments are incorrect since they do not modify the current
CellConstraints - they return a new one.

Original issue reported on code.google.com by vlov...@gmail.com on 22 Mar 2009 at 4:05

[GoogleCodeExporter]

Hi,

In JGoddies those methods are static but in the current GWT implementation, 
since
there is no support for clone(), they are normal methods. This is I think the 
only
difference with JGoodies.

The comments in the forms API should be changed, I know :-( It needs a lot of 
work,
and for the moment its better to fix bugs and add missing features (sorry).

Thanks,
George.

Original comment by georgopo...@gmail.com on 23 Mar 2009 at 8:21

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

Here's a patch I made - not very complicated.  Don't see why you need clone if 
the
rchw methods simply wrap xywh which creates a new Constraint every invocation. 
Comment updates not done.

Original comment by vlov...@gmail.com on 23 Mar 2009 at 12:51

Attachments:

• mosaic.patch

[GoogleCodeExporter]

Oh & don't worry - I find the GWT-mosaic API to be generally far easier to 
understand
than when I tried the GWT-ext libraries.

Original comment by vlov...@gmail.com on 23 Mar 2009 at 12:57